Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singlesig wizard #392

Merged
merged 6 commits into from Sep 17, 2020

Conversation

ben-kaufman
Copy link
Contributor

Adds a wizard for setting up a new device + singlesig wallet.

Also fix #390

@stepansnigirev
Copy link
Collaborator

stepansnigirev commented Sep 15, 2020

Looks good. A few comments:

  1. I would expect that when the user selects the device in the wizard he is forwarded to the next step as there is nothing else to do on this page.
  2. The same on the next page - after I click "Connect over USB" and "Device data was retrieved succesfully" I expect to get to the next page. Maybe makes sense to show somewhere how many keys were imported (not necessary to show the keys, just the number of them). The same should happen for SD card and QR code import.
  3. On "Create new wallet" page let's change the wizard icon to something more wizard-y. Something like this maybe: https://www.svgrepo.com/svg/190631/magic-wand-wizard, and rename to "New wallet wizard"
  4. On the key import step the wizard should check if at least one of the keys (scanned or uploaded) is single sig (has bip 49 / 84 derivation path or is ypub / zpub / upub / vpub). It's annoying to go through the whole wizard and find out you scanned wrong xpub at the very end.
  5. If the wizard fails (i.e. I only scanned multisig xpub) the device should not be created. So makes sense to check if everything went well and if not - clean up.
  6. On wallet creation screen disable nested segwit / native segwit radio button if the corresponding key type is missing. For example I shouldn't be able to scan only zpub and try to create a nested segwit wallet.

@stepansnigirev stepansnigirev merged commit bcd25c7 into cryptoadvance:master Sep 17, 2020
@ben-kaufman ben-kaufman deleted the singlesig-wizard branch September 17, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing Cobo Vault's icon with attachment
3 participants