Use Electron for desktop app #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool, sounds promising! Is this testable by anyone? I guess so, right? |
This reverts commit 7598cab.
|
This seems to break Coldcard HWI connection for some very unclear reason, we'll need to wait with it |
|
Can you convert this PR to draft so we don't merge it by accident? |
ben-kaufman
changed the title
ben-kaufman
changed the title
…fman/specter-desktop into macos-gatekeeper-signing
ben-kaufman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've managed to figure out how to properly sign the macOS app to satisfy the GateKeeper requirements, so no right-click stuff is needed to open the app.Still, the issue with the first launch hanging on forever persists, so we will need to figure out a way around it. I'll try to handle this either in this PR or in a separate one.I've documented the process and automated it except the initial setup which needed only once. I believe there might be future problems with dependencies if we add/ remove some, but I'll also try to document how I fixed that (just get the Apple report if they reject notarization, extract the paths they rejected, add them to the signing script individually, then retry).Edit:
Changed this PR into having a new Electron-based desktop app. This should solve all known issues of the desktop app + support code signing on macOS.
Fix #414
Fix #493
Fix #398
Fix #477 (probably...)