rework discovery of pip installed version #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroPointEnergy
force-pushed
the
pip_version_check
branch
from
e641d5e
to
29049d7
Compare
|
Fixed the formatting issue. Had to redo the whole commit, could not get git to preserve the content of the merge commit on a rebase for some reason. Sorry |
|
Always a pleasure to merge a PR which removes more code than it creates :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across an issue when attempting to create a system wide installation with a package manager that the version could not be identified correctly.
This patch reworks the version discovery and used the importlib_metadata library to find the installed version (https://importlib-metadata.readthedocs.io/en/latest/using.html#using). This is part of python >=3.8, so it is only temporarily a new dependency.
To find the latest version I just made a direct request to the pypi API, which is probably also what pip does, just that we don't have to parse the CLI output and get an easy to parse json.