Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve price #691

Merged
merged 6 commits into from Nov 26, 2020
Merged

Improve price #691

merged 6 commits into from Nov 26, 2020

Conversation

ben-kaufman
Copy link
Contributor

Implemets #664

@k9ert
Copy link
Collaborator

k9ert commented Nov 24, 2020 •
edited

Tested and LGTM

But one thing:
image
Every minute? I think it's every 10 minutes. I think every minute is way too often. Every 10 minutes is fine, imho.

@ben-kaufman
Copy link
Contributor Author

Yes it does happen only once per 10 minutes, the text was wrong, fixed it now

@k9ert k9ert merged commit 2ed9dd7 into master Nov 26, 2020
@ben-kaufman ben-kaufman mentioned this pull request Nov 28, 2020
Closed
@k9ert k9ert deleted the improve-price branch May 19, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k9ert k9ert k9ert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ben-kaufman @k9ert