Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break the controller into blueprints #726

Merged
merged 10 commits into from Dec 3, 2020

Conversation

ben-kaufman
Copy link
Contributor

This breaks the huge Controller file into multiple enpoints:

app.register_blueprint(auth_endpoint, url_prefix="/auth")
app.register_blueprint(devices_endpoint, url_prefix="/devices")
app.register_blueprint(price_endpoint, url_prefix="/price")
app.register_blueprint(settings_endpoint, url_prefix="/settings")
app.register_blueprint(wallets_endpoint, url_prefix="/wallets")

Also moved filters to their own file.
One more thing I didn't do yet (because I think it would make sense to do when adding the API with #713) is to move a few global endpoints (generate mnemonic + a few calls for RPC) to a separate API. I added a TODO for that in the code above the 4 endponts I would like to move to an API endpoint.

This also includes a small bugfix for validating address history on Specter DIY via QR code, the index was wrong...

@k9ert
Copy link
Collaborator

k9ert commented Dec 1, 2020

Nice! As soon as the 3 issues are solved, i'll try to run the cypress tests against this!

@k9ert
Copy link
Collaborator

k9ert commented Dec 2, 2020

I ran the cypress tests and also did some manual testing. LGTM, I'll merge today evening if tests are green and no other issues.

@k9ert k9ert merged commit b52027b into cryptoadvance:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants