Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sortedmulti() descriptor for BIP67 #8

Closed
wants to merge 1 commit into from

Conversation

Sjors
Copy link
Contributor

@Sjors Sjors commented Oct 6, 2019

Depends on Bitcoin Core master (bitcoin/bitcoin#17056)

ColdCard simulator no long complains about BIP67 violation (at least for the one change address that it complained about before).

@stepansnigirev
Copy link
Collaborator

stepansnigirev commented Oct 20, 2019

What worries me is that sortedmulti will break compatibility with current and next release of Bitcoin Core. If I understand correctly 0.19 is in RC already and sortedmulti is scheduled for 0.20 release.
I see two ways to fix it at the moment:

  • Generate addresses in python, add them to Bitcoin Core one by one if Core version doesn't support sortedmulti.
  • Ignore current Core release, merge this pull request and write in the Readme.md that we only support master branch of Core at the moment.

What way should we take?

@Sjors
Copy link
Contributor Author

Sjors commented Oct 21, 2019

sortedmulti is indeed scheduled for 0.20 and it's probably too late to add it to 0.19.

Given that this project is still experimental, I think the best approach is to use Bitcoin Core master, and then switch to 0.20 early next year. Hopefully native descriptor wallets also make it into that release, so you can just use getnewaddress.

@stepansnigirev
Copy link
Collaborator

Fixed with #22
I made a temporary workaround to import sortedmulti addresses in current BitcoinCore release. It sorts the xpubs for every index.

@Sjors Sjors deleted the 2019/10/sortedmulti branch October 29, 2019 15:28
stepansnigirev pushed a commit that referenced this pull request Jul 8, 2020
….4.2

Bump typing-extensions from 3.7.4 to 3.7.4.2
ben-kaufman pushed a commit to ben-kaufman/specter-desktop that referenced this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants