Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass result of createpsbt call back to calculateEstimatedFee #945

Merged
merged 4 commits into from Feb 18, 2021

Conversation

djpnewton
Copy link
Contributor

show the user why the fee estimation failed

@ben-kaufman
Copy link
Contributor

Thanks @djpnewton
There's just a conflict to solve, although I'm not sure why is that change needed?

@djpnewton
Copy link
Contributor Author

fixed the conflict.

the amount sanitation is needed because I was getting the exception string of an invalid "amount" back to the "calculate estimated fee" field. Although that is less likely to occur after a later commit where I use the form validation before calling the fee estimation endpoint

@ben-kaufman ben-kaufman merged commit e41c788 into cryptoadvance:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants