gui: animated qr

[gorazdko]

close #48

Status

Ready for review

Edit

New implementation force pushed which resembles cryptoadvance/specter-desktop#104

[stepansnigirev]

I think it would be better to extend QRCode class defined in
https://github.com/cryptoadvance/specter-diy/blob/master/src/gui/components.py#L15

We could add a method to set max size, and if QR code text is larger than that size - add two arrows on the right and left sides of the qr code. When you click on the arrow - next / prev part of the QR code is shown.
Label under the QR code could show current and total number of qr codes.

What do you think?

[stepansnigirev]

Maybe something like this:

[gorazdko]

I changed the approach as you suggested.

[gorazdko]

I force pushed the implementation which now works the same as cryptoadvance/specter-desktop#104

What should we do with animations in simulator mode? It doesnt look to have a timer.

[gorazdko]

I set the limit at 850 which may be even lower. It needs more testing. The thing is drawing the qr takes alot of RAM, more than 10 times of the qr payload. One thing i noticed also, we can draw a 1KB qrcode in a 300x300 label most of the times but not into a 480x480 label because it requires that much more RAM.

[stepansnigirev]

I think to solve it we could move lvgl buffer to SDRAM in the display driver.
I opened a corresponding issue: diybitcoinhardware/f469-disco#8

For now let's just live with this limitation.

[stepansnigirev]

What should we do with animations in simulator mode? It doesnt look to have a timer.

We can write a simple scheduler where we can register / unregister callbacks. Maybe even look at asyncio.
I think we can do the same both in simulator and on the board itself.
At the moment we have something very similar to asyncio in ioloop() function - we constantly call .update() function on everything that requires updates.

Here is a pure python implementation:
https://github.com/micropython/micropython-lib/blob/master/asyncio_slow/asyncio_slow.py

Recently uasyncio was added to micropython:
micropython/micropython#5332

We can rebase to the latest version of micropython and check that nothing breaks, but I think we should start with pure python implementation.

[gorazdko]

Maybe even look at asyncio

For now I just used ticks.diff for simulator and for stm32 with the .update function, so the code is the same. Is that ok?

In simulator i notice this qr width glitching, it doesnt happen on hardware though:

Its a consequence of the fact that i have to adapt the qr width after i draw it. Will ponder on this one a bit...

[stepansnigirev]

Looks good! I will test a bit and merge :)

[stepansnigirev]

Tested works great, I didn't see any width glitches in the simulator.
On hardware the close button becomes a bit laggy but I think it's ok, we can live with it.

With cryptoadvance/specter-desktop#118 we can use it in specter-desktop.

Now we can sign and display large transactions! Awesome!

[gorazdko]

On hardware the close button becomes a bit laggy but I think it's ok, we can live with it

You mean pressing OK button while animation is running? Weird, I havent noticed that at all. Mine has never lagged and works blazingly fast.

[k9ert]

This should also go into the release, i guess? I'd suggest to quickly merge it and then test everything together?!

[stepansnigirev]

I agree, works great, I don't see a reason not to merge :)