Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include stats for metadata accesses #130

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Conversation

BeyerMart
Copy link
Contributor

With this PR, two new counters are introduced, which increment, when a FileChannel is opened and when Attributes are read.

This allows to show the total amount of accesses and also provides an option to reset the second counter, so the 'Accesses per seconds' can be displayed in Cryptomator.
This feature in CryptoFs is needed for: cryptomator/cryptomator#1511

@overheadhunter
Copy link
Member

@BeyerMart Any chance you can fix the diff of CryptoFileSystemImpl.java? Maybe there is some whitespace or newline reformatting involved here? I can hardly review this line by line manually 🙈

@tobihagemann
Copy link
Member

Just wanted to chime in and confirm that newlines were reformatted. 😄 0x0a20 (old) vs. 0x0d0a20 (new). Either set your IDE to use UNIX line endings (e.g., in IntelliJ IDEA it's in the Preferences under Editor / Code Style and then "Line separator") or you can also set it globally in your git config via git config --global core.autocrlf true.

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@overheadhunter overheadhunter changed the title Feature/include stats for metadata accesses Include stats for metadata accesses May 25, 2022
@overheadhunter overheadhunter added this to the 2.5.0 milestone Oct 6, 2022
@infeo infeo merged commit 530ff75 into develop Nov 16, 2022
@infeo infeo deleted the feature/stats-for-metadata branch November 17, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants