Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load jars from plugin dir #1759

Merged
merged 2 commits into from Aug 24, 2021
Merged

Load jars from plugin dir #1759

merged 2 commits into from Aug 24, 2021

Conversation

overheadhunter
Copy link
Member

This adds a new environment property cryptomator.pluginDir, which fixes #1756.

This is the proposed default value for cryptomator.pluginDir:

OS Default Dir
Linux ~/.local/share/Cryptomator/plugins
Mac ~/Library/Application Support/Cryptomator/Cryptomator/Plugins
Windows ~/AppData/Roaming/Cryptomator/Plugins

If the property is absent or directory is missing or empty, the behaviour is unchanged.

@overheadhunter overheadhunter added this to the 1.6.0 milestone Aug 24, 2021
@overheadhunter overheadhunter merged commit e7b9f73 into develop Aug 24, 2021
@overheadhunter overheadhunter deleted the feature/plugin-loader branch August 24, 2021 17:29
@purejava
Copy link
Contributor

I have some problems in testing, as I am on IntelliJ and ran into #1688 (comment). 🤣

Compiling and running using Maven does not work either due to the new native installers built by the GitHub workflow. At least I could not find executable code, neither in target nor in dist. Or am I missing something? 🙃

As I could not find a download link for IntelliJ EAP, I'll have to switch IDEs ... and come back.

@overheadhunter
Copy link
Member Author

@purejava No need for EAP. IntelliJ IDEA 2021.2 is now officially available.

@purejava
Copy link
Contributor

Thank you for the hint!

I tested this PR (actually I tested the develop branch that included commit aef1bf8) successfully on all three platforms: Windows, Linux and Mac. The plugin was loaded in either case.

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load plugins from external plugin directory
3 participants