Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load plugins from external plugin directory #1756

Closed
2 tasks done
overheadhunter opened this issue Aug 17, 2021 · 1 comment · Fixed by #1759
Closed
2 tasks done

Load plugins from external plugin directory #1756

overheadhunter opened this issue Aug 17, 2021 · 1 comment · Fixed by #1759
Assignees
@overheadhunter
Labels
type:feature-request New feature or request
Milestone
1.6.0

Comments

@overheadhunter
Copy link
Member

Please agree to the following

Summary

Installers should make sure that a dedicated plugin directory is being created and included in the classpath

Motivation

Give plugins such as @purejava's keepassxc-cryptomator some place to live

Considered Alternatives

No response

Anything else?

No response
@overheadhunter overheadhunter added type:feature-request New feature or request misc:installer Affects installer or launcher labels Aug 17, 2021
@overheadhunter
Copy link
Member Author

Turns out, jpackage doesn't give us the options we need. So instead we need a custom class loader that looks up jars in a configurable dir.

@overheadhunter overheadhunter removed the misc:installer Affects installer or launcher label Aug 24, 2021
@overheadhunter overheadhunter self-assigned this Aug 24, 2021
@overheadhunter overheadhunter mentioned this issue Aug 24, 2021
Merged
@overheadhunter overheadhunter added this to the 1.6.0 milestone Aug 24, 2021
@overheadhunter overheadhunter changed the title Launchers should add plugin dir to classpath Load plugins from external plugin directory Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@overheadhunter overheadhunter

Labels
type:feature-request New feature or request
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Load jars from plugin dir cryptomator/cryptomator
1 participant
@overheadhunter