Add Language Chooser #2150
Merged
Add Language Chooser #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
infeo
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Switching the language is a nice to have feature.
Although: i don't like that a language needs to be added manually. Can't we generate some kind of properties file during build and load it via the getResource(String name)? Then we would notice when a new language is added.
infeo
requested changes
Apr 4, 2022
me neither, but I wanted to keep the PR small, since the last one was so big. |
|
Kudos, SonarCloud Quality Gate passed! |
infeo
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2106
Important: When adding a new language, it needs to be added to
SupportedLanguages#LANGUAGAE_TAGSmanually in order to show up in the preferences menu.