Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme / Skin Switch for Dark & Light theme on GUI settings #576

Closed
c055 opened this issue Dec 3, 2015 · 18 comments
Closed

Theme / Skin Switch for Dark & Light theme on GUI settings #576

c055 opened this issue Dec 3, 2015 · 18 comments
Assignees
Milestone

Comments

@c055
Copy link
Collaborator

c055 commented Dec 3, 2015

(or as alternaitve on top right nav)

@c055
Copy link
Collaborator Author

c055 commented Dec 3, 2015

i can do the light skin part .. but maybe i would need some assistance on the js settings switch part ..

@wmbutler
Copy link
Contributor

wmbutler commented Dec 3, 2015

ok, late December

@svk31 svk31 modified the milestones: 2.0.151216, 2.0.151223 Dec 18, 2015
@wmbutler wmbutler modified the milestones: 2.0.160106, 2.0.151223 Dec 29, 2015
@jonnybitcoin
Copy link

Is there any way the less technical amongst us could try out different styles and colours of the gui by making small changes. this would be great for those looking to host there own exchanges/gateways and want to differentiate between others.

@c055
Copy link
Collaborator Author

c055 commented Jan 2, 2016

yep .. this shouldn't be a problem at all, as each skin use its own .scss file ..
(just some chart styles have to get exported to these files as well)

@c055
Copy link
Collaborator Author

c055 commented Jan 2, 2016

sry for the delay btw .. had to create a worker proposal before.. to be able to continue contributing to BTS related tasks directly again asap

@jonnybitcoin
Copy link

great did your worker proposal get approved?

@c055
Copy link
Collaborator Author

c055 commented Jan 2, 2016

just published before 10 secs :)

http://cryptofresh.com/workers

Proposal 1.14.28

@c055
Copy link
Collaborator Author

c055 commented Jan 2, 2016

new proposal 1.14.28

@wmbutler
Copy link
Contributor

@cassiopaia nice, looks like you are going to get it!

svk31 added a commit that referenced this issue Feb 19, 2016
@svk31
Copy link
Contributor

svk31 commented Feb 19, 2016

OK I've just added support for theming, it works by using a mixin _theme-template.scss that you simply pass colors to and it generates a new theme. I've tried to add most selectors that use theme colors to the mix-in, but chances are I missed some, so if you see any feel free to move them to the mix-in.

I also added a colors.js file that contains some theme colors that are used directly in the javascript and can't be applied through css. Probably some are missing here too, so the same applies.

@c055
Copy link
Collaborator Author

c055 commented Feb 20, 2016

nice!

@jonnybitcoin
Copy link

yay, Is there any way for a layman like me to try out different colours themes?

@svk31
Copy link
Contributor

svk31 commented Feb 20, 2016

Do you have the GUI running locally in a dev server?

@jonnybitcoin
Copy link

I got it hosted at http://188.166.149.61:8080/
I've changed some text colours yay! is it just the theme.scss files I should be playing with?

@c055
Copy link
Collaborator Author

c055 commented Feb 21, 2016

currently i'm stucking on getting wallet run locally .. :/ have to dive into more ... once this will work i will create a series of colour themes

@svk31
Copy link
Contributor

svk31 commented Feb 21, 2016

Well you could sure but you'd need to edit the theme colours in the terminal I guess, and make sure you can access the website externally.

@c055
Copy link
Collaborator Author

c055 commented Feb 22, 2016

yea .. before i have to get GUI locally working .. still some local path problems with npm etc .. :/
will ping u then

@c055
Copy link
Collaborator Author

c055 commented Feb 22, 2016

got it thx .. will delete mail here... to avoid spam

@svk31 svk31 closed this as completed Apr 5, 2016
xeroc pushed a commit to BitSharesEurope/testnet.bitshares.eu that referenced this issue Nov 7, 2017
xeroc pushed a commit to BitSharesEurope/testnet.bitshares.eu that referenced this issue Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants