Fixes a bug that caused the CLI wallet to be unable to decrypt memos #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some transactions sent by the web wallet, and vice versa. The shared secret used in to encrypt the memos is derived by computing a 256-bit quantity from the public and private keys. When the high- order byte of this quantity is zero, this implementation was omitting the high-order byte, producing a 248-bit number instead. When passed through the hash function to create the symmetric key, this generated a different key from the C++ implementation which always generates 256-bits. This fix will restore compatibility with the CLI wallet, but will prevent the web wallet from decoding any incompatible memos that were have already been generated.
As I commented in the forum thread, why not patch CLI wallet to be compatible with web wallet? |
|
Merging this but I'll be adding code to handle legacy memos also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some transactions sent by the web wallet, and vice versa.
The shared secret used in to encrypt the memos is derived by computing
a 256-bit quantity from the public and private keys. When the high-
order byte of this quantity is zero, this implementation was omitting
the high-order byte, producing a 248-bit number instead. When passed
through the hash function to create the symmetric key, this generated
a different key from the C++ implementation which always generates
256-bits.
This fix will restore compatibility with the CLI wallet, but will
prevent the web wallet from decoding any incompatible memos that were
have already been generated.
Some discussion here: https://bitsharestalk.org/index.php/topic,22477.0.html