Use &[u8] instead of &Vec<u8>

[panicbit]

No description provided.

[tarcieri]

Thanks for the PR. This covers some but not all of the cases. Also the format is about to change. But since master is in a state of flux anyway, I'll call this an improvement.

[panicbit]

Not sure what you mean exactly. Did I miss some &Vec somewhere?

[tarcieri]

Yes, there are several fields still using Vec<u8>, like identifier and location

[panicbit]

No, those are fine. You'll want to consume the identifier and probably also the location.

[tarcieri]

So playing the devil's advocate: why can't they be immutably borrowed as a &[u8]? (and use e.g. std::borrow::Cow)

[panicbit]

&[u8] would be bad because it would either force you to
a) clone the data, even if the caller doesn't need the original data anymore (unnecessary clone) or
b) add a lifetime parameter to Token (reduced usability)

Cow would allow you to pass either an owned or a borrowed value, but using ToOwned or Into instead would probably be much more ergonomic (the caller wouldn't need to explicitly clone anymore or explicitly create a Cow).