sha3 benchmark #324
Merged
sha3 benchmark #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3881572104
💛 - Coveralls |
59 tasks
duesee
suggested changes
Jan 6, 2023
There was a problem hiding this comment.
Thanks! Looks good so far. Could we also add SHAKE (https://tech.cryspen.com/hacl-packages/c/main/hacl/hash/sha3.html#shake) to complete all of HACL SHA-3? (I would suggest to tackle all EverCrypt hashes separately.)
There was a problem hiding this comment.
We should also add comparison with OpenSSL. But we can do this in a follow up.
Nore that the comparison of benchmarks with main doesn't work because the sha3 benchmark doesn't exist there (same in #323). @pnmadelaine can you change the comparison script to run all benchmarks that are on main, not all that are on the branch?
|
benchmark comparison is fixed in #325 |
pnmadelaine
force-pushed
the
pnmadelaine-sha3-benchmark
branch
from
99efb92
to
1b5cf42
Compare
|
@duesee benchmarks for SHAKE are now implemented |
pnmadelaine
force-pushed
the
pnmadelaine-sha3-benchmark
branch
from
1b5cf42
to
1635ca6
Compare
pnmadelaine
force-pushed
the
pnmadelaine-sha3-benchmark
branch
from
1635ca6
to
b870774
Compare
duesee
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a benchmark for Sha3