Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint/UselessAssign reports type declarations within lib definitions #442

Closed
Sija opened this issue Jan 9, 2024 · 0 comments · Fixed by #443
Closed

Lint/UselessAssign reports type declarations within lib definitions #442

Sija opened this issue Jan 9, 2024 · 0 comments · Fixed by #443
Assignees
@Sija
Labels
false positive
Milestone
1.6.2

Comments

@Sija
Copy link
Member

Sija commented Jan 9, 2024 •
edited

Code below triggers an issue:

lib LibFoo
  struct Foo
    a : Int32
  end
end
@Sija Sija added this to the 1.6.2 milestone Jan 9, 2024
@Sija Sija self-assigned this Jan 9, 2024
Sija added a commit to Sija/gphoto2.cr that referenced this issue Jan 9, 2024
@Sija
Ignore type declarations
739d290 
Until crystal-ameba/ameba#442 is resolved
@Sija Sija mentioned this issue Jan 10, 2024
Merged
@Sija Sija closed this as completed in #443 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sija Sija

Labels
false positive
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

Do not report type declarations within lib definitions crystal-ameba/ameba
1 participant
@Sija