Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not report type declarations within lib definitions #443

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Do not report type declarations within lib definitions #443

merged 2 commits into from
Jan 10, 2024

Conversation

Sija
Copy link
Member

@Sija Sija commented Jan 10, 2024

Resolves #442

@Sija Sija added this to the 1.6.2 milestone Jan 10, 2024
@Sija Sija requested a review from veelenga January 10, 2024 00:15
@Sija Sija self-assigned this Jan 10, 2024
@Sija Sija enabled auto-merge January 10, 2024 00:29
veelenga
veelenga approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Sija Sija merged commit 734bb2a into master Jan 10, 2024
4 checks passed
@Sija Sija deleted the fix-issue-442 branch January 10, 2024 08:12
@Sija Sija mentioned this pull request Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
false positive
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.

Lint/UselessAssign reports type declarations within lib definitions
2 participants
@Sija @veelenga