-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Style/RedundantParentheses
into more general ParenthesesAroundCondition
rule
#302
Conversation
…ignments, refactor existing `RedundantParentheses` rule
71e88b7
to
eabe463
Compare
Style/ParenthesizedAssignments
ruleStyle/RedundantParentheses
to support enforcing parens around assignments
e9d893d
to
6fb61c0
Compare
Also rename the option: `parenthesized_assignments` -> `allow_safe_assignment`
6fb61c0
to
5ee4074
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names of the files should be changed too. The rest looks good to me. Thanks for dealing with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm actually reviewed it on mobile and haven't noticed that file names are properly changed))
LGTM
Style/RedundantParentheses
to support enforcing parens around assignmentsStyle/RedundantParentheses
into more general ParenthesesAroundCondition
rule
This renames the rule to more fitting
ParenthesesAroundCondition
and replacesexclude_assignments
option withallow_safe_assignment
, which if set enforces parens around assignments, and strips them otherwise.Refs #140