Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lint/LiteralAssignmentsInExpressions rule #303

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add Lint/LiteralAssignmentsInExpressions rule #303

merged 1 commit into from
Nov 17, 2022

Conversation

Sija
Copy link
Member

@Sija Sija commented Nov 15, 2022 •
edited

Resolves (partially) #294

@Sija Sija added the rule label Nov 15, 2022
@Sija Sija added this to the 1.3.1 milestone Nov 15, 2022
@Sija Sija requested a review from veelenga November 15, 2022 00:27
@Sija Sija self-assigned this Nov 15, 2022
@veelenga veelenga modified the milestones: 1.3.1, v1.4.0 Nov 15, 2022
@straight-shoota
Copy link
Contributor

This only addresses point 3. of #294, so I think it shouldn't resolve that issue.

@Sija Sija mentioned this pull request Nov 15, 2022
Merged
@Sija Sija force-pushed the Sija/lint-literal-assignments-in-expressions-rule branch from 4029254 to e7a855f Compare November 16, 2022 11:30
@Sija Sija force-pushed the Sija/lint-literal-assignments-in-expressions-rule branch from e7a855f to 5c08b64 Compare November 16, 2022 14:08
@Sija Sija marked this pull request as ready for review November 16, 2022 14:09
@Sija Sija requested a review from veelenga November 16, 2022 14:09
veelenga
veelenga approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 496e893 into master Nov 17, 2022
@Sija Sija deleted the Sija/lint-literal-assignments-in-expressions-rule branch November 17, 2022 13:19
@Sija Sija linked an issue Nov 17, 2022 that may be closed by this pull request
Prefer Yoda Conditionals #163
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
rule
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Prefer Yoda Conditionals
3 participants
@Sija @straight-shoota @veelenga