Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AST::Util#literal? helper #304

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Refactor AST::Util#literal? helper #304

merged 2 commits into from
Nov 16, 2022

Conversation

Sija
Copy link
Member

@Sija Sija commented Nov 15, 2022

@Sija Sija added the refactor label Nov 15, 2022
@Sija Sija added this to the 1.4.0 milestone Nov 15, 2022
@Sija Sija requested a review from veelenga November 15, 2022 16:43
@Sija Sija self-assigned this Nov 15, 2022
@Sija Sija mentioned this pull request Nov 15, 2022
Merged
veelenga
veelenga approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit b5ac599 into master Nov 16, 2022
@Sija Sija deleted the Sija/refactor-ast-util-literal branch November 16, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
refactor
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sija @veelenga