Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Style/QueryBoolMethods rule #314

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Add Style/QueryBoolMethods rule #314

merged 4 commits into from
Dec 8, 2022

Conversation

Sija
Copy link
Member

@Sija Sija commented Nov 30, 2022 •
edited

Reports boolean properties defined with ?-less variants of property / getter macros.

class Person
  property deceased = false
  getter witty = true
end

@Sija Sija added the rule label Nov 30, 2022
@Sija Sija added this to the 1.4.0 milestone Nov 30, 2022
@Sija Sija requested a review from veelenga November 30, 2022 23:15
@Sija Sija self-assigned this Nov 30, 2022
veelenga
veelenga reviewed Dec 1, 2022
View reviewed changes
src/ameba/ast/util.cr Outdated Show resolved Hide resolved
spec/ameba/rule/style/query_bool_methods_spec.cr Show resolved Hide resolved
@Sija Sija force-pushed the Sija/style-query-bool-methods-rule branch from ce1b2d5 to 8029450 Compare December 3, 2022 03:52
@Sija Sija requested a review from veelenga December 8, 2022 01:09
@Sija Sija force-pushed the Sija/style-query-bool-methods-rule branch from 3217a8f to e18da84 Compare December 8, 2022 01:16
veelenga
veelenga approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 150ba6c into master Dec 8, 2022
@Sija Sija deleted the Sija/style-query-bool-methods-rule branch December 8, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
rule
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sija @veelenga