Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specs on Crystal nightly (soon to be v1.7.0) #334

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Fix specs on Crystal nightly (soon to be v1.7.0) #334

merged 3 commits into from
Jan 10, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Dec 21, 2022 •
edited
Loading

Many specs are failing after merging crystal-lang/crystal#11798.

@Sija Sija added this to the 1.5.0 milestone Dec 21, 2022
@Sija Sija requested a review from veelenga December 21, 2022 15:24
@Sija Sija self-assigned this Dec 21, 2022
@Sija
Copy link
Member Author

Sija commented Dec 21, 2022 •
edited
Loading

@veelenga I've fixed all of the specs, aside of Lint/EmptyExpression which is failing. I have no time to dig into this though, perhaps you could take this one over? nvm, it's fixed :)

@Sija Sija force-pushed the Sija/crystal-1.7.0-fixes branch 4 times, most recently from cf3af2c to af321f2 Compare December 21, 2022 16:58
veelenga
veelenga approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija marked this pull request as ready for review January 10, 2023 12:11
@Sija Sija merged commit e58f900 into master Jan 10, 2023
@Sija Sija deleted the Sija/crystal-1.7.0-fixes branch January 10, 2023 12:23
@Sija Sija modified the milestones: 1.5.0, 1.4.0 Jan 10, 2023
@Sija Sija mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
infrastructure
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sija @veelenga