Parser: fix wrong/missing locations of various AST nodes #11798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`else_location` should be `nil` if `else` block is not present.
For example: a, b = 1, 2 if 3
For example: abstract def foo(x)
For example: ::foo
For example: foo.[0] = 1
For example: x : Foo(A, *B, C)
For example: Int[8]?
For example: [1, 2,]
For example:
foo(
&.block
)
For example: foo.bar(x) do; end
For example: %w(one two)
For example:
{%
if foo
bar
end
%}
For example: foo bar, out baz
For example: Foo?
For example: foo : Foo.class foo : Foo? foo : Foo* foo : Foo** foo : Foo[42]
For example: foo ->bar(Baz)
For example:
Foo { 1 }
For example: foo.!
For example: f.x = foo
For example: x : Foo -> Bar
spec/compiler/parser/parser_spec.cr
Outdated
| end_loc = node.end_location.not_nil! | ||
| end_loc.line_number.should eq(line_number) | ||
| end_loc.column_number.should eq(column_number) | ||
| source_between(string, loc, end_loc).should eq(source) |
There was a problem hiding this comment.
What's the purpose of this expectation? I don't see how the source string comparison adds any relevant information to just the end location.
There was a problem hiding this comment.
It’s useful for checking if the start location is set correctly (so maybe I should move this to a separate test). However, I think the string comparison is easier to understand at a glance than line/column numbers (when the test fails), so perhaps we can delete the number comparisons altogether?
|
Where does the internal compiler error come from? |
straight-shoota
approved these changes
Nov 21, 2022
|
Could this make it into 1.7.0, pretty please? :) |
|
CI is 💚 , 2nd review anyone? |
asterite
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've included examples in tests and commit description, but if you want I can split this PR into multiple PRs.