Make postinstall portable #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need for copying the executables manually (which happens in both makefile targets `bin` and `run_file`). Shards' `executables` takes care of that. The makefile targets could potentially be dropped as well, I don't think there would be other uses case for those.
Using `shards build` directly instead of `make build` improves portability a lot. This should basically "just work" almost anywhere (including Windows). No need for `make` to be available and makefile compatibility doesn't matter either.
|
Actually, installing But this is a bug in shards: It always appends |
|
I think we can merge as is. It requires a patched shards on Windows, but postinstall and executables don't currently work there anyway. So this is not making anything worse. And it will start working in the next shards release with crystal-lang/shards#593 merged. |
|
@straight-shoota Wow, thanks for this suggestion. Can we remove |
Sija
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for copying the executables manually (which happens in both makefile targets
binandrun_file).Shards'
executablestakes care of that.The makefile targets could potentially be dropped as well, I don't think there would be other uses case for those.
Using
shards builddirectly instead ofmake buildimproves portability a lot.The result should be identical to the previous behaviour, except that it works on more platforms (including Windows).
Only practical difference is that the executables are linked instead of copied. This could perhaps be a problem for the source file
ameba.cr. It should be fine for the binary.This should basically "just work" almost anywhere because
shardsis always available in the environment. No need formaketo be available and makefile compatibility doesn't matter either.Resolves #368