Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Lint/SharedVarInFiber rule account for loop { ... } #439

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Make Lint/SharedVarInFiber rule account for loop { ... } #439

merged 2 commits into from
Dec 28, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Dec 28, 2023

Closes #353

@Sija Sija added this to the 1.6.1 milestone Dec 28, 2023
@Sija Sija requested a review from veelenga December 28, 2023 13:20
@Sija Sija self-assigned this Dec 28, 2023
@Sija Sija enabled auto-merge December 28, 2023 13:34
veelenga
veelenga reviewed Dec 28, 2023
View reviewed changes
src/ameba/ast/branch.cr Outdated Show resolved Hide resolved
@Sija Sija requested a review from veelenga December 28, 2023 14:28
veelenga
veelenga approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit c9bc01f into master Dec 28, 2023
4 checks passed
@Sija Sija deleted the fix-issue-353 branch December 28, 2023 14:31
@veelenga
Copy link
Member

Oops, auto-merge doesn't wait for the CI status :/

@Sija
Copy link
Member Author

Sija commented Dec 28, 2023

@veelenga I've made the test (<os>, latest) checks required, let's see if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
bug rule
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

Using loop do hides SharedVarInFiber warning
2 participants
@Sija @veelenga