Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented fire method #77

Merged
merged 1 commit into from Oct 24, 2020
Merged

Implemented fire method #77

merged 1 commit into from Oct 24, 2020

Conversation

Iranon
Copy link
Contributor

@Iranon Iranon commented Oct 22, 2020

Before submitting a Pull Request please read and tick this checkbox:

  • I did read the project licensing and I agree with the content of this Pull Request being licensed under the same conditions.

I created a generic ammo folder, with an ammo script inside, and a missile folder with a missile scene and a custom sprite. The smoke effect can be removed for performance issues because it is very small into the level scene.
Missile (or bullet) should rotate with te towers.
I hope everithing is fine.

@davcri
Copy link
Member

davcri commented Oct 22, 2020

Thanks for opening the issue pull request @Iranon! I'm going to review it in the next days! Hopefully tomorrow :)

@davcri davcri merged commit f748c28 into crystal-bit:master Oct 24, 2020
@davcri davcri linked an issue Oct 24, 2020 that may be closed by this pull request
@@ -14,6 +14,7 @@ var contributors = [
"davtur19",
"mRuggi",
"m0rp30",
"Iranon",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davcri
Copy link
Member

davcri commented Oct 24, 2020

Hi @Iranon thanks for the PR, I just merged into master! Finally we have missiles 🚀

I made some changes that you can find here:

Feel free to ask if you have any doubt about it. I thought it was easier to actually show the changes than to write a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Tower.fire() method
2 participants