Quote the File Path

[toddsundsted]

Quote the file path so that spaces in the path don't break the command passed to the shell.

[jwoertink]

Do you have an example where this would fail? Can you add it to https://github.com/crystal-community/icr/blob/master/spec/integration/icr_spec.cr ?

[toddsundsted]

you can reproduce reliably by creating a directory with white space in the name, changing to that directory, invoking icr and trying to run anything. it don't immediately see how to reproduce that in an integration test without manipulating the filesystem in the test, but i'll see if i can cook one up. on my laptop:

$ cd /tmp
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ icr
...
icr(0.27.2) > Hash(String).new
Error: unknown command: /tmp/dir

[bew]

I think it would be even better to not rely on shell splitting mechanism, and properly give the command and args separately since we can:

Process.new(CRYSTAL_COMMAND, {@tmp_file_path, "--no-debug"}, output: io_out, error: io_out)

[toddsundsted]

created #106 using Process.new

will close this PR if that approach is successful

[veelenga]

Closing in favor of #113