Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when path contains spaces #113

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Crashes when path contains spaces #113

merged 3 commits into from
Nov 4, 2019

Conversation

veelenga
Copy link
Member

@veelenga veelenga commented Nov 4, 2019

fixes #112

Copy link
Collaborator

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one small comment otherwise it all looks good to me 👍

spec/integration/icr_spec.cr Outdated Show resolved Hide resolved
@veelenga veelenga merged commit 9310812 into master Nov 4, 2019
@veelenga veelenga deleted the fix/pwd-whitespace branch November 4, 2019 22:04
@stellarpower
Copy link

Nice one! I have come across a few other bugs in the last few hours, I will note them as I find them and either submit an issue or add to any existing ones.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes when path contains spaces
3 participants