Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Handle inmemory files better #2

Closed
kofno opened this issue Aug 17, 2016 · 1 comment
Closed

Handle inmemory files better #2

kofno opened this issue Aug 17, 2016 · 1 comment
Labels

Comments

@kofno
Copy link
Contributor

kofno commented Aug 17, 2016

VSCode will send an inmemory:// file for new files are files that are opened as part of a git diff.

Two problems arise:

  1. Crystal doesn't handle require's from these files, since it can't recognize the in memory path, so error checking them will report false positives.
  2. We aren't cleaning up the reported errors when the inmemory file is closed.

To solve #1, we may want to only run the parser analyzer over inmemory files (and offer them completion services, when those are available).

To solve #2, we should send a clean diagnostic report whenever we close an inmemory file.

@kofno kofno added the bug label Aug 17, 2016
@kofno
Copy link
Contributor Author

kofno commented Aug 22, 2016

Fixed in 940f891

@kofno kofno closed this as completed Aug 22, 2016
@faustinoaq faustinoaq added this to Done in Crystal Tools Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Crystal Tools
  
Done
Development

No branches or pull requests

1 participant