Issues with completion on some files #85
Comments
BTW, There's no errors in that project and also I reloaded VSCode before trying to use auto-completion |
Also, if you see the logs, scry is logging something like: |
hmm that is weird, I'll look into it. |
So, looks like some of my files are not being included in the auto-completion database because some strange reason 😅 |
@laginha87 I checked the logs and the file |
Seems there is something wrong with these lines: scry/src/scry/completion/dependency_graph.cr Lines 77 to 79 in bf2660b
|
@laginha87 Can you reproduce this issue? 😅 |
I did some test, this bugs seems to be related to the If a try a new clean crystal project but not on Surprisingly If a try an amber project, auto-completion feature work without problems in all files: (even in files outside So, I really don't know what is happening here 😅 I think we need to review this code: scry/src/scry/completion/dependency_graph.cr Lines 67 to 79 in bf2660b
|
@laginha87 here are the scry logs for
Sorry for so many comments and Thank you for your help! 😅 👍 |
No worries, sorry I haven't had time to look at these yet. |
Hi @laginha87 I guess I fixed something in #92 Std lib Completion for all crystal files is working now, even in untitled files 🎉 |
Wow, I think #92 fixes this definitely, see my comment: #92 (comment) |
It's very odd, cause in that case reload would have fixed issue (temporarily at least) |
@laginha87 maybe this issue was caused by #59 and #91, so when the |
@laginha87 I knew I had some issues with auto-completion feature and I have found them, sometimes the completion is broken in projects with sub directories. And keep working only in the main project file.
In the example below, I tried scry master and tested completion on all files, (
baz.cr
,bar.cr
andfoo.cr
) and no one works but onlyconsole.cr
. No matter where I put them, completion just work on one file, the main fileconsole.cr
for the projectconsole
Full logs here: https://gist.github.com/faustinoaq/65b39e810dc1e4a6a3456bb0286d48e6
The text was updated successfully, but these errors were encountered: