Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

60 laginha87 methoddb generation more resilient #62

Merged
merged 5 commits into from
Apr 9, 2018

Conversation

laginha87
Copy link
Contributor

Fix for #60

ezgif com-video-to-gif 2

I added an invalid sample to the the spec fixtures, it broke the format check :(

@faustinoaq
Copy link
Member

Hi, Thank you again! This is a great PR 🎉

I'm testing it and I have found some issues, I gonna record some gifs to explain it better 👍

@laginha87
Copy link
Contributor Author

@faustinoaq thanks for reviewing my PR, could you explain the issues you found?

@faustinoaq
Copy link
Member

could you explain the issues you found?

Hi @laginha87 , yeah, currently I'm writing something about this, so sorry for the late reply, I was a bit busy latest weeks 😅

@faustinoaq faustinoaq added this to Done in Crystal Tools Apr 6, 2018
@faustinoaq faustinoaq moved this from Done to In progress in Crystal Tools Apr 6, 2018
@faustinoaq
Copy link
Member

This PR is working very nice, I had some issues unrelated to this PR (the diagnostic analyzer was killing the scry process, already fixed on #76 ), my bad 😅

A screen capture:

ezgif-4-4ef51a83c2

BTW, @laginha87 I just read this:

Note: If you 're trying this out in vscode because dependancies are preloaded, Run Reload the Window after saving the files.

So, VSCode needs to be reloaded when the files are changed, Do exist some way to avoid this?
I mean, reloading the editor to get latest completion is bit heavy and repetitive task IMO 😅

@faustinoaq faustinoaq merged commit b38f2df into master Apr 9, 2018
Crystal Tools automation moved this from In progress to Done Apr 9, 2018
@faustinoaq faustinoaq deleted the 60-laginha87-methoddb-generation-more-resilient branch April 9, 2018 18:47
@faustinoaq
Copy link
Member

Update: I just found #61

@laginha87 I guess you're already aware of that issue 😉

Sorry por the late reply and Thank you so much for your collaboration!. 👍 💯

@faustinoaq
Copy link
Member

faustinoaq commented Apr 11, 2018

I'm testing it and I have found some issues, I gonna record some gifs to explain it better +1

I knew I had some issues with auto-completion feature and I have found them

I opened a new issue here: #85

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Crystal Tools
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants