Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Send back single formatted TextEdit #37

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

bmulvihill
Copy link
Contributor

Fixes #35

  • Formats document with a single TextEdit rather than many since we end up formatting the entire source anyway

@faustinoaq
Copy link
Member

@bmulvihill Thanks you!

This bug is my fault 😅

I tried to fix a bug, related to files above 10000 characters, I thought this was because I was using a single TextEdit, so I implemented multiples Textedit 1 Then I found I was using content.size instead of content.bytesize 2 but my bad implementation kept in codebase 😅

  1. # NOTE: Some clients don't support newText bigger that 10000 characters.

  2. 57dad79#diff-786bcb9064e3287ebb531cf94135c945R28

@faustinoaq faustinoaq merged commit dcfade5 into crystal-lang-tools:master Oct 24, 2017
@faustinoaq faustinoaq added this to Done in Crystal Tools Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Crystal Tools
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants