This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fixes autocompletion when constructor has integer or boolean params #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initializers with integers and booleans in them.
|
@laginha87 Looks like Travis found some formatter changes, see: https://travis-ci.org/crystal-lang-tools/scry/jobs/363996490#L520 |
|
@crystal-lang-tools/scry I guess this is the last PR before releasing a new version 😅 Should we release |
|
v0.8.0 |
faustinoaq
suggested changes
Apr 9, 2018
laginha87
changed the title
laginha87
changed the title
faustinoaq
approved these changes
Apr 9, 2018
laginha87
changed the title
|
@faustinoaq seems travis is ok and so are you, LGTM ? |
|
@bararchy Yeah, I approved, just waiting another approval to merge it 👍 |
keplersj
approved these changes
Apr 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issue.
On this scenario:
The current implementation identifies the type of a as an integer when it should be A.