Respect explicitly provided type vars for (Named)Tuple.new #10047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Dec 8, 2020
| @@ -35,7 +35,22 @@ struct NamedTuple | |||
| # {} # syntax error | |||
| # ``` | |||
| def self.new(**options : **T) | |||
| options | |||
| {% if @type.name(generic_args: false) == "NamedTuple" %} | |||
There was a problem hiding this comment.
Note to self: it would be nice to know whether a type is an uninstantiated generic using a macro call.
There was a problem hiding this comment.
By the way, this works slightly differently from the Slice.[] example because it's not possible to attach generic type vars to the macro call directly; they can only be attached via aliases (i.e. Bytes[...] is legal while Slice(UInt8)[...] isn't).
Sija
reviewed
Dec 8, 2020
straight-shoota
approved these changes
Dec 18, 2020
bcardiff
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10041.