Rename URI#full_path to URI#request_target #10099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Dec 30, 2020
saltycrys
added a commit
to saltycrys/invidious
that referenced
this pull request
Feb 2, 2021
Rename `HTTPClient@socket` to `HTTPClient@io`, see crystal-lang/crystal#9543. Rename `URI#full_path` to `URI#request_target`, see crystal-lang/crystal#10099.
FireMasterK
pushed a commit
to StuffNoOneCaresAbout/invidious
that referenced
this pull request
Feb 4, 2021
Rename `HTTPClient@socket` to `HTTPClient@io`, see crystal-lang/crystal#9543. Rename `URI#full_path` to `URI#request_target`, see crystal-lang/crystal#10099.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full_pathis an unspecified term and open to interpretation.pathin an URI context is justpathand there is no "full" version of it.The intention of this method is direct at extracting an HTTP request target in origin form. So it should be named appropriately.
This also includes a minor behavioural change: for opaque URIs the path does not default to
/when empty. Otherwise it would turn an opaque URI into a hierarchical one. This method would typically not be used with opaque URI's, but it doesn't hurt to be complete on this.Closes #9990