Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: fix while condition assignment check for Not #10347

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Compiler: fix while condition assignment check for Not #10347

merged 1 commit into from
Feb 1, 2021

Conversation

asterite
Copy link
Member

@asterite asterite commented Feb 1, 2021

Fixes #10345

@asterite asterite added kind:bug topic:compiler:semantic kind:regression Something that used to correctly work but no longer works labels Feb 1, 2021
@asterite asterite changed the title Compiler: fix logic that detects assignments inside while condition Compiler: fix while condition assignment check for Not Feb 1, 2021
@asterite asterite added this to the 0.36.1 milestone Feb 1, 2021
@asterite asterite merged commit 63a3c51 into master Feb 1, 2021
@asterite asterite deleted the bug/while-cond branch February 1, 2021 11:10
bcardiff pushed a commit that referenced this pull request Feb 2, 2021
@asterite @bcardiff
Compiler: fix while condition assignment check for Not (#10347)
c3a3c18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:compiler:semantic
Projects
None yet
Milestone
0.36.1
Development

Successfully merging this pull request may close these issues.

[BUG] compilator accepts any methods for x after until x = 1 || nil
2 participants
@asterite @straight-shoota