Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ssl context add_x509_verify_flags #10756

Merged
merged 2 commits into from
Jun 1, 2021
Merged

fix ssl context add_x509_verify_flags #10756

merged 2 commits into from
Jun 1, 2021

Conversation

stakach
Copy link
Contributor

@stakach stakach commented May 28, 2021

invalid type specified on function, solving:

> 46 | def add_x509_verify_flags(flags : OpenSSL::X509VerifyFlags)
                                         ^-----------------------
Error: undefined constant OpenSSL::X509VerifyFlags

@stakach
fix ssl context add_x509_verify_flags
6c90751 
invalid type specified on function
@stakach @caspiano
Update src/openssl/ssl/context.cr
b88741e 
Co-authored-by: Caspian Baska <email@caspian.computer>
asterite
asterite approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@straight-shoota straight-shoota added this to the 1.1.0 milestone May 29, 2021
@Sija
Copy link
Contributor

Sija commented Jun 1, 2021

@straight-shoota Was closing this issue intentional?

@straight-shoota
Copy link
Member

@Sija No, sry. Must have misclicked. I wanted to hit the merge button 😆

@straight-shoota straight-shoota merged commit 9bf9152 into crystal-lang:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspiano caspiano caspiano left review comments

@asterite asterite asterite approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:crypto
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stakach @Sija @straight-shoota @asterite @caspiano