Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow Slice(T).new(Int) where T is a union of primitive number types #10982

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Disallow Slice(T).new(Int) where T is a union of primitive number types #10982

merged 1 commit into from
Jul 23, 2021

Conversation

HertzDevil
Copy link
Contributor

Fixes #10980.

@HertzDevil HertzDevil changed the title Disallow unions of primitive types for Slice.new(Int) Disallow Slice(T).new(Int) where T is a union of primitive number types Jul 22, 2021
@Sija
Copy link
Contributor

Sija commented Jul 22, 2021

Some specs would be good to have.

@straight-shoota straight-shoota added this to the 1.2.0 milestone Jul 22, 2021
@straight-shoota straight-shoota merged commit 6395c01 into crystal-lang:master Jul 23, 2021
@HertzDevil HertzDevil deleted the bug/slice-new-primitive branch July 24, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:collection
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Overloaded Slice.new(Int) should not be acceptable for a union of primitive types
4 participants
@HertzDevil @Sija @asterite @straight-shoota