Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add build matrix with 1.0.0 and 1.1.1 #11278

Conversation

straight-shoota
Copy link
Member

In order to ensure compatibility with older Crystal releases, we need to run specs for that.

This is just a first step. We're duplicating the specs for test_linux to run with both, the latest stable release (1.1.1) and its predecessor (1.0.0).

It's still open how we want to progress in the future. For example, how long we keep 1.0.0 as the lower bound and if we add tests for more releases between upper and lower bound. That's to be determined at a later point.

See https://forum.crystal-lang.org/t/compiler-compilability/3651 for the discussion thread.

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I <3 this

@straight-shoota
Copy link
Member Author

We should consider doing more stuff with build matrices. But after this.

@straight-shoota straight-shoota added this to the 1.2.0 milestone Oct 6, 2021
@straight-shoota straight-shoota merged commit 317cd10 into crystal-lang:master Oct 6, 2021
@straight-shoota straight-shoota deleted the feature/test-against-older-crystal branch October 6, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants