Use MPIR for Big* numbers on Windows
#11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprypin
reviewed
Nov 9, 2021
straight-shoota
approved these changes
Nov 9, 2021
oprypin
approved these changes
Nov 11, 2021
oprypin
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
BigInt,BigFloat,BigRational, andBigDecimaltypes on Windows by using MPIR, an API-compatible fork of GMP. The main benefit is it provides Visual Studio projects, so setup on CI is quite easy compared to GMP's autoconf-based workflow. All existingBig*-related specs pass except for the accuracy loss inBigFloat#**(GMP and MPIR do nothing about this, but MPFR does; see #11410).Due to the size differences of
LibC::Longbetween Linux 64-bit and Windows 64-bit, GMP probably wouldn't work on the latter even if it successfully compiles. But we don't need to switch to MPIR for the former either, since GMP is readily available there.