Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing debug locations to constant / class variable read calls #11417

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Add missing debug locations to constant / class variable read calls #11417

merged 4 commits into from
Nov 9, 2021

Conversation

HertzDevil
Copy link
Contributor

Fixes #11416.

Although the constant read functions have a debug location, for some reason the calls themselves to the read functions do not. This PR adds them.

@HertzDevil HertzDevil added kind:bug kind:regression Something that used to correctly work but no longer works topic:compiler:debugger labels Nov 8, 2021
beta-ziliani
beta-ziliani approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HertzDevil !

@beta-ziliani beta-ziliani added this to the 1.2.2 milestone Nov 8, 2021
straight-shoota
straight-shoota reviewed Nov 8, 2021
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a spec for reading a class var as well?

spec/compiler/codegen/debug_spec.cr Outdated Show resolved Hide resolved
@HertzDevil HertzDevil changed the title Add missing debug locations to constant read calls Add missing debug locations to constant / class variable read calls Nov 9, 2021
@beta-ziliani beta-ziliani merged commit e5bf6b9 into crystal-lang:master Nov 9, 2021
straight-shoota pushed a commit that referenced this pull request Nov 9, 2021
@HertzDevil @straight-shoota
Add missing debug locations to constant / class variable read calls (#…
6134b04 
…11417)

Fixes #11416.

Although the constant read functions have a debug location, for some reason the calls themselves to the read functions do not. This PR adds them.
@HertzDevil HertzDevil deleted the bug/const-read-debug-loc branch November 14, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:compiler:debugger
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

Missing debug information for constant read
3 participants
@HertzDevil @straight-shoota @beta-ziliani