Fix CI rules for building libiconv on Windows #11504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:regression
oprypin
approved these changes
Nov 28, 2021
|
I think this is finally it |
oprypin
approved these changes
Nov 29, 2021
straight-shoota
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11480 (comment). Alternative to #11502.
The current repository that we use to build libiconv has no potential license issues, because it references the files in
libcharset/include, neversrclib: https://github.com/pffang/libiconv-for-Windows/blob/9b7aba8da6e125ef33912fa4412779279f204003/libiconv.vcxproj#L62-L63This approach is also less error-prone because we are no longer editing the .vcxproj files in-place.