Fix compiler specs git integration for configurable default branch #11754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Jan 19, 2022
HertzDevil
reviewed
Jan 19, 2022
|
Ideally there should be a spec for when |
It is fairly common to define "main" as the default branch name, and specs should not fail if that is configured. Therefore a new branch is checked out after initializing a new git repo for the specs that are dependent on the branch name.
yxhuvud
force-pushed
the
fix/specs-use-default-git-branch
branch
from
337070d
to
65084c9
Compare
|
Updated based on #11753 (comment) . Instead of being dependent on the default branch name, it will always create a new one. There is really nothing in the behaviors being tested that care about if the branch was created by default or not. |
straight-shoota
approved these changes
Jan 22, 2022
straight-shoota
approved these changes
Jan 23, 2022
oprypin
approved these changes
Jan 27, 2022
straight-shoota
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is fairly common to define "main" as the default branch name, and
specs should not fail if that is configured.
Fixes #11753