Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler (fix): lookup return type in defining type #11962

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

asterite
Copy link
Member

@asterite asterite commented Apr 2, 2022

Fixes #11961

We (me? :-P) were incorrectly looking the return type on the instantiated type instead of the defining type.

For Enumerable#max the return type is T. That's correctly Int32 in the failing example, but it's Tuple(Int32, Int32) in the context of Tuple.

@HertzDevil HertzDevil added kind:bug topic:compiler:semantic kind:regression Something that used to correctly work but no longer works labels Apr 2, 2022
@beta-ziliani beta-ziliani added this to the 1.4.0 milestone Apr 4, 2022
@straight-shoota straight-shoota merged commit 6b55fef into master Apr 4, 2022
@straight-shoota straight-shoota deleted the bug/11961-lookup-type-in-defining-type branch April 4, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:compiler:semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inference breaks inside a tuple when assigning to an ivar (regression on master)
4 participants