Allow the EventLoop implementation to be detected at runtime #12656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
topic:stdlib:concurrency
kind:refactor
topic:stdlib:runtime
and removed
topic:stdlib:runtime
labels
straight-shoota
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #10740 / #10768.
Currently each target must implement the event loop interface, which is a module with static methods. This PR changes the module to be an abstract class instead. The goal is to support systems where multiple event loops are available and can be selected at runtime (Linux with io_uring, for example). No additional event loop implementation is introduced here.
The event loop instance is held by an instance variable at
Crystal::Scheduler(one per thread) and can be accessed withCrystal::Scheduler.event_loop. This is not a public API!#10768 will later be refactored on top of this PR.