Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Number comparison operator docs #12880

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix Number comparison operator docs #12880

merged 1 commit into from
Jan 4, 2023

Conversation

fdocr
Copy link
Contributor

@fdocr fdocr commented Dec 30, 2022

I noticed the docs for <=> method mentioned the operator returns -1 in scenarios self > other and self < other. Hope this fix is right 🙂

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs topic:stdlib:numeric labels Dec 30, 2022
@beta-ziliani beta-ziliani added this to the 1.7.0 milestone Jan 3, 2023
@straight-shoota straight-shoota merged commit 59b77bc into crystal-lang:master Jan 4, 2023
@fdocr fdocr deleted the comparison-operator-doc-fix branch January 5, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs topic:stdlib:numeric
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fdocr @straight-shoota @beta-ziliani @Blacksmoke16