Add BigDecimal#%
#13255
Merged
Add BigDecimal#%
#13255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From ghosted PR crystal-lang#9784
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
HertzDevil
approved these changes
Mar 31, 2023
|
Looks like ARM 64bit is failing on the stdlib. Any way to see the error or reproduce it? See https://github.com/crystal-lang/crystal/actions/runs/4577670506/jobs/8083403907?pr=13255 |
|
It's unrelated to this PR |
straight-shoota
approved these changes
Mar 31, 2023
straight-shoota
changed the title
BigDecimal#%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ghosted PR #9784. The branch is no longer accessible, but I've applied the patch and confirmed that the spec passes and adheres to the style.
This should fix #9782.