Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compile-time error for Range#size, #each, #sample #13278

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Remove compile-time error for Range#size, #each, #sample #13278

merged 1 commit into from
Apr 5, 2023

Conversation

straight-shoota
Copy link
Member

Resolves #13121

@straight-shoota straight-shoota self-assigned this Apr 4, 2023
@straight-shoota straight-shoota added this to the 1.8.0 milestone Apr 4, 2023
@straight-shoota straight-shoota merged commit 251137c into crystal-lang:master Apr 5, 2023
@straight-shoota straight-shoota deleted the fix/range-raise-nil branch April 5, 2023 13:16
@HertzDevil
Copy link
Contributor

It seems this requires unimplemented functionality in the interpreter

@Sija
Copy link
Contributor

Sija commented Apr 5, 2023

Btw, why nil is not being shown in the error message?

Error: compiling (::Range.new(3, , false)).reverse_each do

https://github.com/crystal-lang/crystal/actions/runs/4609247266/jobs/8148834738#step:6:1151

@straight-shoota straight-shoota mentioned this pull request Apr 5, 2023
Closed
@straight-shoota straight-shoota mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil approved these changes

Assignees

@straight-shoota straight-shoota

Labels
breaking-change kind:bug topic:stdlib:collection
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Range#size raises compile time error
4 participants
@straight-shoota @HertzDevil @Sija @beta-ziliani