Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an interpreter spec for check crystal i is running on linux. #14192

Closed

Conversation

zw963
Copy link
Contributor

@zw963 zw963 commented Jan 9, 2024

No description provided.

@straight-shoota
Copy link
Member

What's the point of this?
It seems this spec checks if an installed crystal compiler has interpreter support? That doen't make any sense because such a compiler binary would be completely independent of the spec context.

@zw963
Copy link
Contributor Author

zw963 commented Jan 9, 2024

What's the point of this? It seems this spec checks if an installed crystal compiler has interpreter support? That doen't make any sense because such a compiler binary would be completely independent of the spec context.

Because build 1.11.0 on Arch Linux successful but crystal i failed, see https://forum.crystal-lang.org/t/crystal-1-11-has-been-released/6284/4?u=zw963
If I remember correctly, and it really running failed this time, this should be the second time the interpreter has broken?

So, instead of .build/crystal i should work? test on this no side effect.

@HertzDevil
Copy link
Contributor

The interpreter specs are fully runnable even if no Crystal installations ever expose the REPL functionality in the command-line interface. I don't see how the two concepts are related

@beta-ziliani
Copy link
Member

The interpreter is tested in Linux, see for example https://github.com/crystal-lang/crystal/actions/runs/7460577216/job/20299250229?pr=14189 .

There might be an issue with Arch, or with any Linux distribution not tested in our CI, but that's a different topic.

@zw963
Copy link
Contributor Author

zw963 commented Jan 10, 2024

The interpreter is tested in Linux, see for example https://github.com/crystal-lang/crystal/actions/runs/7460577216/job/20299250229?pr=14189 .

There might be an issue with Arch, or with any Linux distribution not tested in our CI, but that's a different topic.

Hi, i thought this spec should be fix to let spec failed before merge #14198 @straight-shoota

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants